delete max elasped duration#787
Open
feiyang3cat wants to merge 1 commit into
Open
Conversation
5 tasks
prathyushpv
reviewed
May 26, 2026
| message TimeSkippingConfig { | ||
| reserved 2, 6; | ||
| reserved "disable_propagation", "max_target_time"; | ||
| reserved 2, 5, 6; |
Contributor
There was a problem hiding this comment.
Nobody uses this feature so far. So I wonder do we need to reserve these fields, and just reuse these numbers?
prathyushpv
approved these changes
May 26, 2026
prathyushpv
reviewed
May 26, 2026
| @@ -625,11 +625,6 @@ message TimeSkippingConfig { | |||
| oneof bound { | |||
Contributor
There was a problem hiding this comment.
Do we need this oneof field if we only have max_skipped_duration? Are we planning to keep add more option in the future?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
delete max_elapsed_duration still in a compatible way in this pr
Why?
Breaking changes
this feature is already implemented and merged in server as this project is huge we merge it feature by feature, so this api should be merged only after the corresponding server pr to delete it merged
Server PR
temporalio/temporal#10387